drew

Done:

-> Worked on:

• bug 866407 - Ctrl-N in private mode creates a new non-private window and restores session
• bug 866444 - Use get/setIcon to restore tab icons and remove 'image' from xulAttributes
• bug 820738 - Intermittent browsernewtabblock.js | grid status = 0,1,2,3,6,7,8,9
• bug 867142 - Remove browser._SSrestoreState and use a WeakMap instead
• bug 861757 - browsertabviewbug610242.js shouldn't use

-> Feedback and review:

• bug 866444 - Use get/setIcon to restore tab icons and remove 'image' from xulAttributes
• bug 838577 - [SessionStore] Cut SaveState in asynchronous chunks
• bug 869910 - [New Tab Page] Allow to undo unpinning a site
• bug 871057 - Simplify session store initialization

-> Coordination:

• Monday off
• attended Scotland.JS
• attended JSDay in Italy
• de:hacking meetup wrap-up

Done:

• reviews
• patches to several sg* bugs. Waiting for right time to land
• debugging animated background image handling, bug 865511

Done:

Notable:

• Bug 853864 - Expose IPC message information to profiler
• some mentoring (bug 844858, bug 863773)
• local webmaker project at school

Done:

• Posted job description for stability job and blogged about it at http://benjamin.smedbergs.us/blog/2013-03-07/do-you-love-your-debugger/
• phone screens
• reviews
• Extended crashinject to be standalone and not require a separate DLL, also can search for firefox.exe and kill it. See https://github.com/bsmedberg/crashfirefox-intentionally or download http://benjamin.smedbergs.us/crashfirefox.exe
• Worked with AMD engineering to reproduce and work around driver bugs that seem to be corrupting Firefox memory. See bug 830531.
• Bunch of small stuff
• Fixing longstanding component manager locking issue with better fatal asserts. r?bent on bug 684887

Done:

Bugs 838947, 835946, 836247, 839877, 844596, 845670, 838155 - all about access to Bugzilla data - data provided as a temporary fix while we find a new home for it.

Confirmed in 846910 that the text referring researchers to the license agreement should be changed to just connect them to me, pending finding more data

Seized control of the Education mailing list, planning to use it to coordinate with webmaker/hive/other education stakeholders.

Enjoyed using the word "seized" in a professional context.

Tried to kill the crash-analysis machine with an ill-advised wget on Friday. Apology and fix on Saturday.

Interviewed a bunch of developers about entry-point bugs - first bugs, mentored bugs, etc. Results to be published to dev-planning shortly.

Done:

Since last status update at the end of September:

• Landed Sqlite.jsm in Toolkit. All async interface to SQLite. It performs statement management for you. It has an API to minimize memory usage. It's nice. Use it.
• Firefox Health Report landed in Firefox 19. Then 20. It's finally riding the trains in Firefox 21 (at least once it is enabled later this week).
• Largely finished initial moz.build conversion work (bug 784841). Should land soon.
• Reviewed rewritten packager code (enabled Metro landing).

Done:

• Slowly generating Servo bindings for ClientRect
• Detoured into rustc bugs with const function pointers
• Further detours into Servo build system oddities
• More detours into allowing constant ascii byte strings in Rust
• Reviewed Safari-like cookie policy changes: bug 818340
• Private browsing mop-up: bug 829360, bug 829383
• Download manager API improvement: bug 830271
• Refinements to higher accuracy settings for geolocation requests: bug 832411
• Investigating necko-related b2g crasher: bug 832796
• Counting volunteers for gear budget purposes
• General #introduction/email engagement

Done:

• New patches:

  • bug 818360 - Canceling file picker since WRL port crashes MetroFx
  • bug 818365 - Open input file controls without accept attributes specified should accept all file types
  • bug 818516 - Assertion hit when it shouldn't be when saving files in Metro for default extension
  • bug 818792 - New private browsing indirectly breaks saving files in Metro Firefox
  • bug 789461 - Create a new directory service entry for the directory containing firefox.exe

• Misc:

  • Defined Metro iteration 2 bugs
  • Worked on bug 817641 - Worked on this task (search doesn't go until pane is dismissed) but didn't find a solution yet

• Filed:

  • bug 817640 - IE10 lists more apps that you can share to in comparison to Firefox
  • bug 817641 - Page doesn't load when searching from the search charm until the search panel is dismissed
  • bug 817677 - Sharing in Firefox Metro should only share selected content when selection is made
  • bug 817679 - Right clicking on an image should allow the user to share that image via the share contract
  • bug 818360 - Canceling file picker since WRL port crashes MetroFx
  • bug 818365 - Open input file controls without accept attributes specified should accept all file types
  • bug 818516 - Assertion hit when it shouldn't be when saving files in Metro for default extension
  • bug 818792 - New private browsing indirectly breaks saving files in Metro Firefox

• Other:

  • bug 711475 - Allow updates to be applied from limited user accounts. Provided info for where to get started to the contributor the task is assigned to.

• Reviews / Feedback reviews:

  • bug 812584 - [OTA update] When network issues interrupt the update, the UI still incorrectly says "Downloading updates..." forever
  • bug 817723 - Only build the stub installer when building x86 and the update channel equals nightly, aurora, beta, and release
  • bug 759639 - Intermittent failure w/ updater test_0202
  • bug 818854 - MetroWidget should set mOnDestroyCalled properly

Done:

• Lots of reviews
• Got a start on HTMLDocument bindings
• A few branch patches for WebIDL issues

Done:

- Implemented review comments for bug 795832 - synthesized input events - Thought of and implemented a way to avoid SetCursorPos in bug 795832 - Attempted to get on-screen keyboard to appear by synthesizing click in URL bar - That didn't work, so tested manually clicking in URL bar - Filed bug 809629 about clicking in URL bar not showing soft keyboard - turns out this is expected behavior - Submitted, backed out, fixed, resubmitted patch for bug 795832 - Switched to building locally with VS2010, switched to building release builds - Debugged remaining issue with metro chrome tests; browser hangs while unloading a DLL during shutdown, but log is written - Implementing chrome tests - Updated browser_context_ui.js to test right-click interaction with context UI

Done:

• Got Windows 8 running and Metro Firefox building
• bug 779527 - resolution media query broken on Android
• bug 786062 - remove unused PanZoom:PanZoom observer

Done:

• Finished the direct proxy class refactor
• Created an implementation plan for implementing Harmony modules
• Found some dead code whilst writing a patch for bug 767059
• Filed a patch for bug 703537
• Filed a patch for bug 720619
• Filed a patch for bug 771907
• Filed a patch for bug 771908
• Tried (and failed) to reproduce compiler error for bug 722555 locally

Done:

• Triage and Reviews (shocking I know)
• Landed a fix for storing Cache.Trash#### files in the Android cache folder bug 754575
• Packing boxes

Done:

• command execute handler prep for review
• finished up xul fennec code base move. This is as far as I can get things until we work out the mixed platform/app resources problem.
• fixed pymake/make issues with reg scripts.
• fixed a bug with the dummy vccor dll that showed up with our builders.
• upgrading local systems to new win8 release / VS tool set.

Done:

• Submitted pdf.js packaging work for review (bug 740795)
• Patched a problem on OSX with FAT filesystem profiles (bug 733436)
• Patched a problem with restartless add-ons when moving profiles between machines (bug 744833)
• Added some quoting for the extensions crash report annotation (bug 753900)
• Thoughts on shipping the SDK in Firefox and problems with supporting other apps: https://etherpad.mozilla.org/SDK-in-Firefox

Done:

• Continued work on bug 653881, to change how xbl insertion points are handled, now with only three test failures. Worked on moving some code over to iterators instead of slower node lists.
• Bug 665677, fix frequently failing test by removing it. The functionality is tested elsewhere.
• Investigated a crash with templates in bug 742455. Caused by a race condition where a document is being evicted from the bfcache while data is still loading. Rafael is looking into a fix.
• Bug 750808, where the label binding which handles accesskeys was deleting the children element. Currently this doesn't cause a problem, but it affects xbl work where insertion points are handled differently.

Done:

During this week, various pieces of the webapp runtime and installer (which I worked on) were landed, and this Thursday the last remaining major pieces made their way to mozilla-central, so this work will be seem on Nightlies tomorrow. Of course, this is the first landing of v1, but it was an important milestone. Now the immediate goal is to take care of follow-ups and smooth everything out during the aurora stabilization period.

These are the main bugs related to webapps that I worked on the past few weeks:

• bug 731541 - Webapp installer for Windows
• bug 739636 - Webapp installer for Mac
• bug 740957 - Webapp installer doorhanger should show a standard icon, not the icon related to the app
• bug 735680 - Update icons for webapps with the newer art
• bug 744674 - use the new shortcut api to create webapp shortcut on Windows
• bug 746369 - support installation of apps that do not specify an icon
• bug 746848 - create pref for installer dry-run (for tests)
• bug 747205 - follow-ups for the installer spec
• a bunch of triage and bug organization and tried to be around and helpful on other work going on

(and big thanks for all the reviewers on these bugs for the exceptionally fast reviews)

Other reviews that I did recently:

• bug 711552 - click-to-play UI
• bug 711618 - click-to-play site-specific permissions
• bug 632634 - use longer hover link status popup for long URLs
• bug 744964 - use plugin icon instead of add-on icon for click-to-play
• bug 741549 - Mochitests for navigator.mozApps
• bug 745757 - simplify CSS selectors related to tabsontop
• bug 746629 - missing webapp-uninstaller from packaged version
• bug 746213 - support mozApps.getSelf in the webapp runtime

Done:

• Work Week last week for Identity derailed some development

Made some progress on bug 673432 "Mobile implementation crypto.getRandomValues" - this bug also governs re-adding a crypto object to window on mobile platforms

Worked on bug 734076 - I have a working patch, there are some unanswered questions yet

Done:

• xfer responsibility for proposal for HTML page localization in SDK-based addons to ochameau
• move to Labs
• appify a website and publish it in the Developer Preview of the Apps Marketplace https://apps-preview.mozilla.org/en-US/apps/app/egg-timer/
• conduct Jetpack Features meeting https://wiki.mozilla.org/Jetpack/Features/2012-01-27
• review and provide feedback on Apps goals

Done:

• Site settings menuitem (bug 706876)
• Click-to-play plugins follow-ups

Done:

• Reviewed bug 699051 - Track slow sql queries on main thread + send them in via telemetry
• Reviewed bug 465299 - mozStorageStatementWrapper::Initialize should check statement state/validity
• Reviewed bug 702815 - Maintain a list of open SQLite connections
• Reviewed bug 703143 - Use a memory multi-reporter for SQLite's per-connection reporting
• Reviewed bug 557047 - Replace mailnews specific ifdef (MOZ_MAIL_NEWS) in cookie code with tests for a protocol flag

Done:

• worked on my Task thing, http://hg.mozilla.org/users/dwillcoxon_mozilla.com/taskgroup/file/tip
• worked on bug 561450, Make session ID generation asynchronous

Done:

• patch for Bug 692487 - Decrease SQLITE DEFAULT CACHE SIZE
• patch for Bug 658303 - mozIStorageConnection::Clone() should copy over #pragmas
• recovered old patch for Bug 697032 - deCOMtaminate FeedProcessor
• fixed Bug 695554 - Split a Database class out of the History service
• fixed Bug 696900 - Avoid any shutdown work in Places when possible
• fixed Bug 658305 - Use journalsizelimit on places.sqlite
• fixed Bug 692120 - The star button doesn't need to observe bookmarks changes till bookmarks service is alive
• fixed Bug 696159 - Remove some deprecated Places code
• feedback Bug 672324 - Fix test for bug 650509 (Other apps can read Firefox profile files)
• feedback Bug 566746 - Form history should use asynchronous storage API
• review Bug 646993 - Cap the bookmark title length to TITLELENGTHMAX r=mak
• review Bug 697992 - Use DebugOnly/NSWARNIF_FALSE in dom/src/storage/nsDOMStorage.cpp
• review Bug 696163 - Remove default livemark
• review Bug 697989 - don't use domstorage-flush-timer in dom/tests/mochitest/localstorage/test_bug624047.html
• review Bug 688913 - Some db connections are not being closed
• review Bug 697856 - Removed Unused Function Definitions in nsFaviconService.h
• review Bug 697410 - Hide snippets container when it's empty
• review Bug 696404 - close connections and misc cleanups in toolkit/components/satchel
• Discussed Ts Shutdown improvements with ateam
• inbound sheriffing

Done:

• work week, belated Independence Day
• landed cross-process d3d10, un-landed for breaking bookmark test in fennec (argh!!!)
• fixed gecko SDK issue with exception wrapping in VC10
• removed another reached NS_NOTREACHED() in TabChild
• some plans for how plugins will work with multiple content processes

Done:

(Extremely busy week, so not much done)

review bug 534764 review bug 623948 analyzes bug 637657 bug 637361 bug 638179 bug 638218

Done:

• Made it through all Firebug-critical beta blockers, so took a break to play with some other things
• Updated the 'slowcalls' stuff to catch more contexts. Hitting information overload as a result. Perhaps group by principal? http://people.mozilla.org/~sfink/slowcalls-proto/slowcalls.html
• Polished up my modifications to mozilla-archer to make it display the compartment of gcthings (if you turn the option on). Some other mozilla-archer fixes.
• Belatedly noticed that I still have a final blocker (bug 631742). Have patch.
• Expanded bug 606629 (JM instruction counter) into bug 637393, providing a complete picture of how many times each instruction is executed. Hopefully useful for code coverage tests, performance checks, etc.
• Blog post on gdb tips & tricks: http://blog.mozilla.com/sfink/2011/02/22/fun-with-gdb/
• A couple of enhancements to bugzilla-tweaks. Ehsan blogged about it: http://ehsanakhgari.org/blog/2011-02-22/bugzilla-tweaks-getting-some-attention-again

Done:

• bug 604897 - Unable to cache small entries when CACHE00[1-3]_ is full
• bug 599127 - Wyciwyg channel write's end up doing synchronous disk IO
• bug 592422 - preallocate individual (non-block) cache files
• bug 597224 - HTTP Cache: use directory tree to store cache files

Done:

r+ on startupcache crash patch (bug 595924). Fixed tests for async launch, but cjones suggests a new approach (bug 592768). Got r+ for all pieces in stat invalidation bug (bug 594058). Some failures on try that I haven't investigated, passes all the tests in mozapps/extensions locally. r+ on partial fix for startupcache fragmentation (bug 593349). r+ for prefixing in startupcache (bug 588335).

Done:

bug #549767 (flush cache-metadata off main thread): new approach, some discussion

bug #589296 (Crash in [@ nsHttpChannel::ContinueProcessResponse): lots of analysis and thinking

bug #561276 (Cookie dependency on cache determination for image redirects): patch submitted and reviewed

Done:

• IndexedDB event security work
• Moving cycle collector off the main thread

Done:

• Mainly worked on Bug 551274 - Update nsAddonRepository for API version 1.5:
  • Adds functionality needed for my current project
  • Adds a bunch of missing tests for AddonRepository.jsm
• Landed Bug 558287 - Add support for searching add-ons on AMO via the addon manager's search bar
• Fixed small bugs:
  • Bug 580379 - Move and improve CSS introduced in Bug 558287
  • Bug 578467 - xpinstall.whitelist.add prefs are not emptied when converted into permissions on startup with new profile

Done:

• paternity break
• bug 536273 (Http POST)
• bug 506269 at last :-) (506269)
• bug 543739 (xpcshell tests for libpref) two quick fixes:
• bug 566869
• bug 569270

Done:

• Have buildbot infrastructure up and running for slow-network simulation to test HTML5 speculative parsing performance.
• Had meeting with jorendorff, bz, and gal about implementing virtual properties in the JS engine.
• Made progress towards implementing the final nsIJetpack/PJetpack multi-process API (thanks to recursive IPDL structs/unions).

Done:

Working on bugs/enhancement requests on the topfails website.

Tried [ unsuccessfully ] to create a backPort tracking application for changeset landings. The idea is to ask for a release branch and check if all the relevant landings on the branch are ported appropriately to all the current & active named-branches. Unfortunately, the logic of deciphering what are current active named branches on a given release is not trivial.

Done:

• Got first review of Tab matches in Awesomebar.
• Started work on new Extension Manager UI.

Done:

• xpcshell builds and runs

Done:

Work on bug 516749, finalized the parent/chrome side.

Done:

Can now build Bespin Embedded releases