ddahl

Done:

• bug 853864 - IPC message information - data looks valid, test written, review pending
• bug 872969 - Java & scripting: "not a function" - looks like no easy fix from our side
• bug 645846 - getLocationOnScreen returns wrong coordinates on Mac
• bug 883671 - Really remove plugin.exposefullpath ...

Done:

* Added a build progress footer to mach (bug 873720) * FHR now stores important state in files, not preferences (bug 846133) * Wrote blog posts on Mercurial * http://gregoryszorc.com/blog/2013/05/12/thoughts-on-mercurial-(and-git) * http://gregoryszorc.com/blog/2013/05/13/the-state-of-mercurial-at-mozilla * Wrote blog posts on build system * http://gregoryszorc.com/blog/2013/05/13/mozilla-build-system-brain-dump * http://gregoryszorc.com/blog/2013/05/13/build-system-status-update-2013-05-14 * http://gregoryszorc.com/blog/2013/05/19/using-docker-to-build-firefox * Went on 2 week vacation to western Europe. Survived. Caught head cold. * Drudged through 2500+ emails and bug updates. Likely missed many important updates. * mconnor broke up with me and bsmedberg is now my manager. * Mentoring new intern: Stefan Mirea. Based in SF. He'll be working on Firefox Health Report. * Mentoring new intern: Christopher Manchester. Based in SF. He's actually ctalbert's intern, but I'm his mentor. He'll be working on structured logging and enabling easier machine readable output from automation [so we can make TBPL and other tools do cooler things]. * Reviewed bug 869635 (eliminate master xpcshell.ini manifest) (it's now generated from moz.build data) * Review bug 874132 - Android SDK 22 support in build system. * Continue to help/review Mike de Boer's work to author a unified JS testing harness. * Review bug 870774 - Async.jsm module * Review bug 873126 - Assert.jsm module * Duplicate aborted sessions in FHR (bug 881991) * Continue to investigate orphaned records in FHR

Done:

• Bug 866928 - Don't show toolbars in customization mode that are collapsed when not in customization mode
• Bug 870901 - Make Edit control customizable
• Bug 870897 - Make Zoom control customizable
• Bug 878824 - updateEditUIVisibility() should check for presence of edit controls widget
• Bug 868433 - Make built-in widgets use localization strings

Done:

• Bug 755593 - Remove tabs-on-bottom mode
• Bug 879994 - LightweightThemeManager should allow lightweight themes to be temporarily disabled
• Bug 870602 - Disable lightweight themes when in customization mode
• Bug 881385 - Remove checks for text iconmodes in browser-social.js
• Bug 879941 - Fix typo in LightweightThemeManager.jsm
• Bug 880568 - docheckeq/docheckneq/do_print should put double-quotes around argument if the typeof argument is "string"
• Bug 880573 - Remove duplication between doreportresult and docheck_neq

Done:

• Finished and landed Bug 769348 - Change URLs autofill prefix behavior
• Posted corrective patch for Bug 702559 - Create a pure-async mozIStorageAsyncConnection
• Review Bug 555120 - Intermittent failure in browser_bug441778.js | zoom is retained after sub-document load
• Review Bug 818593 - Add file size to bookmarks restore UI
• Feedback Bug 846644 - Use asynchronous getCharsetForURI in PlacesUtils.jsm
• Review Bug 860119 - Live-update about:home when defaultEngine changes
• Review Bug 861613 - request for toggable download animation
• Review Bug 865555 - Remove synchronous setCharsetForURI in BI_importJSONNode
• Review Bug 878411 - crash in mozilla::storage::Connection::internalClose @ sqlite3WalClose
• Review Bug 878690 - SafariProfileMigrator.js should use FormHistory.jsm
• Review Bug 880399 - Re-land star button changes for User Research build

Done:

• Prioritized remaining work on the Downloads API
• Filed bugs for converting promise consumers to the new module
• Reviewed Downloads API and Application Reputation bugs

Done:

• Big ol' M7 triage for Australis. Final stretch!
• Participated in UI review on Australis tabs

Fixed the following:

• Bug 851001 - Update close icons on UX branch
• Bug 873066 - Enforce allowedAreaTypes for widgets (bounced due to orange, still working on it)
• Bug 880399 - Move star button out from URL bar into the bookmarks-menu-button. (UX branch)
• Bug 880421 - Bump migration currentUIVersions for removing text&icons mode and un-collapsing nav-bar in nsBrowserGlue.js

• Bug 880789 - Remove the dropmarker from the Bookmarks button when its in the palette or panel

• Explored some potential performance optimizations for customization mode transitions with bwinton

• Wrote a patch to make the download panel open the downloads history view when in the menu panel
• Wrote scripts for creating disposable profiles for user testing (cloning default profile, creating new profile)
• Took over and started to update Bug 856665 - Australis toolbar buttons for OS X

Reviews:

• Bug 879147 - OS X titlebar placeholders are incorrect in RTL mode
• Bug 875297 - Move the contents of the initialize method into the constructor of the search-textbox binding (new contributor patch)
• Bug 871279 - (Australis) Some pop-up windows show the tabs too high in the titlebar
• Bug 870602 - Disable lightweight themes when in customization mode
• Bug 870452 - When the Subscribe toolbaritem is in the panel, it should show a subview if there are more than 1 available feeds
• Bug 879977 - Restore Defaults button should be disabled, not hidden, when in the default state

Done:

-> Worked on:

• bug 879375 - Intermittent browsertabopenreflows.js | unexpected uninterruptible reflow 'ssi_getWindowDimension@...'
• bug 881661 - BrowserNewTabPreloader._collectTabBrowserSizes() still flushes layout when querying tabbrowser bounds
• bug 879752 - Test failure "controller.waitForPageLoad(): Timeout waiting for page loaded" in testNewTab.js
• bug 794041 - nsAccDocManager shouldn't create a RootAccessible for the hiddenWindow
• bug 878747 - browser.stop() call in addTab() is expensive and causes reflows
• bug 881590 - Talos Tp5 (and other) regressions from new tab page preloading
• bug 791670 - [New Tab Page] enable new tab page preloading by default
• bug 879733 - Provide API to temporarily suppress layout flushes
• bug 879745 - Make Panorama tests clean up after themselves

-> Filed bugs:

• bug 881661 - BrowserNewTabPreloader._collectTabBrowserSizes() still flushes layout when querying tabbrowser bounds
• bug 879741 - Decide whether Accessibles should be created for hidden windows
• bug 879733 - Provide API to temporarily suppress layout flushes
• bug 879745 - Make Panorama tests clean up after themselves

-> Feedback and review: + bug 870105 - Resolve BackgroundPageThumbs's use of nsIDOMWindowUtils.setCSSViewport

Done:

• bug 853389 - AddonRepository - All patches r+. Hoping to have a green try run by today and patches ready to push tomorrow. Patch queue depends on one patch from bug 853388
• bug 880555 - Fixed --test-manifest option for mochitest-chrome
• GSoC mentoring
• FISL planning Reviews and feedback:
• bug 666809
• bug 878606
• bug 853388

(was out on Friday)

Done:

• Coordination with UR for upcoming Australis user testing
• Initial planning for Australis intro blog posts and such
• Email thread on getting UX for a post-Firefox-reset "welcome back" page design
• Battling unexpected breakage in password manager refactoring (839961)
• The usual slew of meetings and 1:1s

Done:

• Yahoo PIN Brute force mitigation
• Bug #881014 - Cancel buttons in UI should call RP's oncancel method

Done:

Done:

• Bug 871931 camera/mic button support for social
• Bug 880741 add indexeddb to frameworker

In Progress:

• Bug 809085 permissions UI for social content

Need Feedback:

• Bug 878905 - improve camera button menuitem labels

Done:

Australis

• Fixed bug 870452, bug 879980 (Subviews for the feed button, followup to get the disabled state correct)
• Fixed bug 877447 (Make customization's .inDefaultState skip non-existing items)
• Fixed bug 877851 (reorganize some test implementation stuff)
• Fixed bug 878775 (retina bug with history favicons)
• Fixed bug 879317 (customization bug affecting jetpack toolbarbuttons)
• Fixed bug 871279, bug 879162, bug 879581 (Menubar/tab-position correcting on Windows)
• Fixed bug 879977 (disable rather than hide the restore defaults button)
• Fixed bug 880322 (remove remnants of icons property support)
• Landed bug 870471 (Context menu for the panel)
• Patched bug 879506 (Windows menubar stuff for popup windows that don't display the menubar), waiting for review from Dao
• Working on bug 877335 / bug 875488 (New icons everywhere!), writing a small tool to help write -moz-region CSS for sprites
• Working on bug 879590 (menubar foreground color on non-glass Windows)
• Working on bug 749804 (add-on bar migration)
  • This is progressing. I'm still fiddling to determine the width of items so as to decide where they should go, but generally I'm pleased with how well it works. Things don't break too terribly with different add-ons, right now everything ends up in the menupanel though. Also, some of the widgets are wide enough so as to end up making the menupanel bigger. Not OK. Still working on a solution for that.
• Triage
• Reviews
• Orange test fighting (mostly unproductive in the end)

Firefox Reset Reviving bug 833943 (migrate tabs/windows/groups when resetting Firefox), waiting for reviews from MattN and ttaubert

Other

• Fixed bug 879961 (remove some obsolete files)
• Patched bug 880752 (nicer Console.jsm stdout/err output, waiting for review from jwalker)

Done:

Async spell check

• Bug 856270 - Update nsEditorSpellCheck to use nsIContentPrefService2
  • landed
• Bug 863430 - Add a reftest-spellchecker API
  • landed
• Bug 880237 - crash in mozInlineSpellChecker::IgnoreWords
  • landed
• Bug 880595 - Recent changes making spell check more async (Bug 856270) broke spell check in Thunderbird
  • filed this bug that broke Thunderbird

Async browser full zoom

• Bug 555120 - Intermittent failure in browser_bug441778.js
  • landed
• Bug 856595 - Intermittent testwheeldefault_action.html
  • fixed by previous bug
• Bug 880361 - "browser is undefined" error when immediately closing a newly opened browser window
  • landed
• Bug 880226 - Intermittent browser_bug386835.js
  • working on this

Background thumbnails

• Bug 875986 - BackgroundPageThumbs should be able to capture private thumbnails while private browsing is active
  • requirements discussion
• Bug 870100 - Use BackgroundPageThumbs to capture user top sites that we don't currently capture
  • met with Boriss, Mark, and Gavin to discuss
• Bug 870105 - Resolve BackgroundPageThumbs's use of nsIDOMWindowUtils.setCSSViewport
  • landed
• Bug 759964 - Add attribute to docshell to disable HTML5 media
  • working on mochitest for this, trying to get it landed
• Bug 875157 - BackgroundPageThumbs should block the HTTP basic authentication dialog
  • reviewed

Other

• Bug 879772 - Intermittent browser/base/content/test/browser_pluginCrashCommentAndURL.js
  • investigated, not much to be done here, maybe update the test to bail when no minidump found
• triaged Firefox::Untriaged

Done:

• Experimental patch for panels in an e10s world
• Investigate async form history in sync
• A few reviews/feedbacks on patches
• Tiny amount of forward progress on e10s forms
• Landing bug to change storage notifications to a doorhanger.
• Nice relaxing long-weekend :)

Done:

• Posted job description for stability job and blogged about it at http://benjamin.smedbergs.us/blog/2013-03-07/do-you-love-your-debugger/
• phone screens
• reviews
• Extended crashinject to be standalone and not require a separate DLL, also can search for firefox.exe and kill it. See https://github.com/bsmedberg/crashfirefox-intentionally or download http://benjamin.smedbergs.us/crashfirefox.exe
• Worked with AMD engineering to reproduce and work around driver bugs that seem to be corrupting Firefox memory. See bug 830531.
• Bunch of small stuff
• Fixing longstanding component manager locking issue with better fatal asserts. r?bent on bug 684887

Done:

Bugs 838947, 835946, 836247, 839877, 844596, 845670, 838155 - all about access to Bugzilla data - data provided as a temporary fix while we find a new home for it.

Confirmed in 846910 that the text referring researchers to the license agreement should be changed to just connect them to me, pending finding more data

Seized control of the Education mailing list, planning to use it to coordinate with webmaker/hive/other education stakeholders.

Enjoyed using the word "seized" in a professional context.

Tried to kill the crash-analysis machine with an ill-advised wget on Friday. Apology and fix on Saturday.

Interviewed a bunch of developers about entry-point bugs - first bugs, mentored bugs, etc. Results to be published to dev-planning shortly.

Done:

- Implemented review comments for bug 795832 - synthesized input events - Thought of and implemented a way to avoid SetCursorPos in bug 795832 - Attempted to get on-screen keyboard to appear by synthesizing click in URL bar - That didn't work, so tested manually clicking in URL bar - Filed bug 809629 about clicking in URL bar not showing soft keyboard - turns out this is expected behavior - Submitted, backed out, fixed, resubmitted patch for bug 795832 - Switched to building locally with VS2010, switched to building release builds - Debugged remaining issue with metro chrome tests; browser hangs while unloading a DLL during shutdown, but log is written - Implementing chrome tests - Updated browser_context_ui.js to test right-click interaction with context UI

Done:

• Got Windows 8 running and Metro Firefox building
• bug 779527 - resolution media query broken on Android
• bug 786062 - remove unused PanZoom:PanZoom observer

Done:

• Finished the direct proxy class refactor
• Created an implementation plan for implementing Harmony modules
• Found some dead code whilst writing a patch for bug 767059
• Filed a patch for bug 703537
• Filed a patch for bug 720619
• Filed a patch for bug 771907
• Filed a patch for bug 771908
• Tried (and failed) to reproduce compiler error for bug 722555 locally

Done:

• command execute handler prep for review
• finished up xul fennec code base move. This is as far as I can get things until we work out the mixed platform/app resources problem.
• fixed pymake/make issues with reg scripts.
• fixed a bug with the dummy vccor dll that showed up with our builders.
• upgrading local systems to new win8 release / VS tool set.

Done:

• Submitted pdf.js packaging work for review (bug 740795)
• Patched a problem on OSX with FAT filesystem profiles (bug 733436)
• Patched a problem with restartless add-ons when moving profiles between machines (bug 744833)
• Added some quoting for the extensions crash report annotation (bug 753900)
• Thoughts on shipping the SDK in Firefox and problems with supporting other apps: https://etherpad.mozilla.org/SDK-in-Firefox

Done:

• Continued work on bug 653881, to change how xbl insertion points are handled, now with only three test failures. Worked on moving some code over to iterators instead of slower node lists.
• Bug 665677, fix frequently failing test by removing it. The functionality is tested elsewhere.
• Investigated a crash with templates in bug 742455. Caused by a race condition where a document is being evicted from the bfcache while data is still loading. Rafael is looking into a fix.
• Bug 750808, where the label binding which handles accesskeys was deleting the children element. Currently this doesn't cause a problem, but it affects xbl work where insertion points are handled differently.

Done:

• Work Week last week for Identity derailed some development

Made some progress on bug 673432 "Mobile implementation crypto.getRandomValues" - this bug also governs re-adding a crypto object to window on mobile platforms

Worked on bug 734076 - I have a working patch, there are some unanswered questions yet

Done:

• xfer responsibility for proposal for HTML page localization in SDK-based addons to ochameau
• move to Labs
• appify a website and publish it in the Developer Preview of the Apps Marketplace https://apps-preview.mozilla.org/en-US/apps/app/egg-timer/
• conduct Jetpack Features meeting https://wiki.mozilla.org/Jetpack/Features/2012-01-27
• review and provide feedback on Apps goals

Done:

• Site settings menuitem (bug 706876)
• Click-to-play plugins follow-ups

Done:

• Reviewed bug 699051 - Track slow sql queries on main thread + send them in via telemetry
• Reviewed bug 465299 - mozStorageStatementWrapper::Initialize should check statement state/validity
• Reviewed bug 702815 - Maintain a list of open SQLite connections
• Reviewed bug 703143 - Use a memory multi-reporter for SQLite's per-connection reporting
• Reviewed bug 557047 - Replace mailnews specific ifdef (MOZ_MAIL_NEWS) in cookie code with tests for a protocol flag

Done:

(Extremely busy week, so not much done)

review bug 534764 review bug 623948 analyzes bug 637657 bug 637361 bug 638179 bug 638218

Done:

• bug 604897 - Unable to cache small entries when CACHE00[1-3]_ is full
• bug 599127 - Wyciwyg channel write's end up doing synchronous disk IO
• bug 592422 - preallocate individual (non-block) cache files
• bug 597224 - HTTP Cache: use directory tree to store cache files

Done:

bug #549767 (flush cache-metadata off main thread): new approach, some discussion

bug #589296 (Crash in [@ nsHttpChannel::ContinueProcessResponse): lots of analysis and thinking

bug #561276 (Cookie dependency on cache determination for image redirects): patch submitted and reviewed

Done:

• Mainly worked on Bug 551274 - Update nsAddonRepository for API version 1.5:
  • Adds functionality needed for my current project
  • Adds a bunch of missing tests for AddonRepository.jsm
• Landed Bug 558287 - Add support for searching add-ons on AMO via the addon manager's search bar
• Fixed small bugs:
  • Bug 580379 - Move and improve CSS introduced in Bug 558287
  • Bug 578467 - xpinstall.whitelist.add prefs are not emptied when converted into permissions on startup with new profile

Done:

Working on bugs/enhancement requests on the topfails website.

Tried [ unsuccessfully ] to create a backPort tracking application for changeset landings. The idea is to ask for a release branch and check if all the relevant landings on the branch are ported appropriately to all the current & active named-branches. Unfortunately, the logic of deciphering what are current active named branches on a given release is not trivial.

Done:

• Got first review of Tab matches in Awesomebar.
• Started work on new Extension Manager UI.

Done:

• xpcshell builds and runs

Done:

Can now build Bespin Embedded releases