bienvenu: All Posts

Done:

• Reviews and Driving
• Fixed bug 575864, lose collapsed message pane and other state when close and re-open last three pane window w/o shutting down the app.
• Fixed bug 392680 Clicking Get Mail twice or during startup (while first round not finished) returns modal "This folder is being processed. Please wait until processing is complete to get messages." dialog / error message [pop]
• Wrote unit test for bug 564737 - first line of plain text messages indented by two spaces.
• Submitted several other patches for review

Done:

• Reviews and Driving
• Started post 3.1 backend plans discussion
• Got maildir support to pass the first 15 xpcshell tests
• Figured out why tests that should fail were passing and proposed a fix - bug 580108
• Continued work on autosync improvements, specifically unit tests

Done:

Mozilla Summit

Reviews and Driving

Got Berkeley mailbox store working again in pluggable store

Done:

<li> Reviews and Driving. </li> <li> Fixed bug 572065 can't save or detach imap attachments, and added unit tests for same. </li> <li> Fixed bug 558543 return receipt notification bar shouldn't appear after the first time the user responds to the request, for local mail. </li> <li> Lots of work on bug 575740 adapt to component mgr changes </li> <li> With SOC student Andreycpp@gmail.com, got pluggable store repo able to download mail to and read mail from maildir store plugin. http://hg.mozilla.org/users/bienvenu_nventure.com/plugstore/ </li>

Done:

Reviews and driving

bug 534158 if smtp server doesn't advertise auth mechanisms, try to send mail directly

fix bug 562104 w/ unit test, crash when subscribed to imap folder '/'

fix for bug 482432, crash in nsImapMailFolderCopyState::OnStopRunningUrl

add ability to open mork db's asynchronously, and unit test, bug 570582

bug 571800 alert undoing imap delete, along with unit test

expose existing method via idl to get thread containing msg hdr, and add thread id to xf view thread, bug 572094

More work on pluggable store

More work on auto sync

Done:

Reviews and Driving

Wrote patch and tests for async db opening for large .msf files bug 570852

Did a couple more revs on pluggable store patch - added FinishNewMessage notification, cleaned up no longer used code.

Done:

Reviews and Driving

All Hands meetings in YVR

Helped with patch for kindler gentler imap autosync upgrade - bug 569161

landed bug 533928 on trunk and 3.1 - collapsed parent with child with new messages is not invalidated when new msgs arrive

fixed bug 570138 for trunk and 3.1, username probing doesn't adjust outgoing server username at same time

More work on pluggable store

Done:

Reviews and Driving

Vacation

fix saving imap drafts offline on windows, bug 397910

fix bug 537815, crash if addr db is closed before addr enumerator freed

don't retry imap move copies since that most likely will result in duplicates, add test for timeout of move/copies, bug 403603

fix crash in msgquotephraseoraddr, bug 564698

potential fix for bug 564898, crash in nsMsgAccountManager::RemoveFolderFromSmartFolder

fixed bug 466933 error getting pop3 mail after resuming from sleep mode

More work on pluggable stores, including keyword modification, and pop3 uidl handling

Done:

Reviews and Driving

fix , we don't offer to send unsent messages when autodetecting online state

Helped diagnose and test Import 'Everything' crunches existing mail

Got message move/copying and flag changing working with pluggable stores, which means delete works

ported fix+test for , handle smtp servers that drop connection on auth, to 3.0.5, and landed.

Investigated top crashes

Done:

Reviews and Driving

3.1 version of fix for bug Bug 545126 HTML Mail View very slow (45++ sec) for pop and local folders

Landed several fixes for 3.0.5

More work on pluggable storage bug 402392

worked on making autosync better about keeping things up to date - bug 562115

Helped a few GS users who had problems upgrading to 3.0 with profile paths on different drives - investigating protential bug

Done:

Reviews and Driving

fix reload of cross-folder saved searches after local folder compact, and add mozmill test bug 536676

Helped with the patch to add an option to maintain folder structure when doing archive , bug 522761

Helped with the Windows Live Mail settings import patch Bug 394687

Done:

Reviews and Driving

Made significant progress on pluggable storage mechanism - bug 402392

Made imap password prompts serial, using new async prompter service, bug 557622

Allow modification of smart folder scope, and dynamically update scope when special folders are added/removed, bug 532061

fix mac dock counts doubling unread messages for accounts with . in the user name, bug 557960

Done:

Reviews and driving

Fixed bug 546384, compacting with imap delete model can mess up offline store, and leak tmp files

Fixed bug 542259, handle smtp servers that drop connection on auth failure, and retry url

Worked on Christophe's patch for Bug 522761, which adds an option to keep the folder structure when archiving, fixed pref handling and added to mozmill archiving test

Found cause of and fix for dock count doubling bug 557960

Investigating failure to get pop3 mail after mac wakes from sleep. Generated try server build with more logging Bug 466933

Done:

Reviews and driving

Add account name to imap alert messages, bug 66860

Fix rename of imap folder to non-ascii name, bug 549220

Fix crash doing STATUS on imap folders, 550455

Fix bug 495020, unread folders view jumps around when additional folders are get unread messages

Worked with Neil's buffered file i/o for networked drives so that it passes unit tests

Done:

Code reviews and driving

Fixed bug 549457, handle imap servers that drop the connection on starttls

Worked on patch and unit test for offline imap store compaction issues bug 546384 and related bugs

Finished patch and mozmill test for bug 532061, which allows editing of smart folder searches and keeps them up to date using various notifications

Done:

Code reviews and driving

Finished review of BenB's mail auth patch

Landed several fixes for 3.0.4

A little consulting on the funnel project

Fixed bug 547564, mac file names with : can't be read in pop3 server accounts

Fixed drag drop of news message to local folder leaving local folder locked, bug 545993

Worked on 3.1 b2 blockers

More work on pluggable stores

Wrote a patch for IMAP EXTERNAL auth

Done:

Code reviews and driving

Worked with BenB on his mail auth patch

Helped several Get Satisfaction users

Fixed offline playback of imap moves to multiple folders with flag changes, with unit test

Fixed mac dock double count of unread messages on startup, , and added logging

Fixed memory leaks when doing offline imap operations without a msg window (e.g., xpcshell tests),

Fixed , imap list leaves db's open, leading to heavy resource consumption, if imap subscription is turned off.

Fixed problems trying to copy to imap sent folder after closing 3-pane window,

Done:

Code reviews and driving

Helped several users with various Get Satisfaction issues

practice firedrill

3.03 firedrill

Debugged tests in bug 538139 - figured out why they were broken for TB

Worked on patches for various 3.1 blockers, stalled on code reviews and closed tree

Done:

More triage and code reviews

Cleaned up my bug list a bit

Landed fix for 3.1 b1 blocker add pop3 activity to activity manager, bug 535437

Make exception in clearing message pane not hork the whole 3 pane window, bug 545933, and found root cause of issue (nsLocation clearing out user+password from uri)

Fixed bug 534858, collapse of thread with killed sub-threads can crash

Fixed bug 537551, invalid array index in nsImapFlagAndUidState::GetMessageFlagsFromUID

Wrote a patch for logging Mac dock count calcuations, generated try server build - bug 516477

Done:

Did a lot of 3.1 triage

Did a bunch of code reviews

Fixed bug 533640, 2.0 to 3.0 upgrade loses folders with ':' in name on mac. Wrote unit test and landed for 3.02

Fixed bug 540214, checking all imap folders for new messages leaves all db's open, added unit test, and landed for 3.02

Did some work on pluggable local mail storage

Done:

ported fix for bug 440236 to 2.024 and landed

Landed some more 3.02 patches

Made some progress on clearing out my review queue and landing contributor patches, including bug 541149, bug 537594, bug 498212 and Bug 504504

Did some 3.1 blocker nomination triage

Wrote some doc on the mailnews search api and some information about the backend impl and sent to jenzed

Found and landed fix + unit test for bug 541969 which caused some smart folders to not include some folders in results.

Landed fix + unit test for bug 505465 which cleans up several different kinds of account duplication.

Done:

Got a 2.0.24 environment setup on Windows, and landed some patches for 2.0.24

Landed some patches for 3.02

Investigated some Get Satisfaction issues

turn off secure auth probing on migration from 2.0 to 3.0, bug 522633

fix bug 462880 update .msf file when server reports 0 existing messages, w/ unit test

treat local messages as offline in cross folder searches for the purposes of enabling commands, r/sr=neil, bug 538810

add account name for pop3 accounts for smart mailboxes, bug 448568

Continued work on bug 533640, upgrade from 2.0 on Mac has issues with folders with ':' in names

Done:

Land >4GB offline store fix on trunk - bug 532323

Done:

landed several patches for 2.0.24

Done:

Landed a bunch of fixes for 3.01 - bug 538414, bug 534835, bug 537820, bug 534382 and several others. Main fixes were for global inbox upgrade issues, IMAP Condstore, quick search in smart folders, and libmime crashes.

Done:

landed trunk version of patch for bug 524902, which should help quite a bit with condstore IMAP servers.

Put up patch for review for dealing with Exchange servers returning bogus message size - bug 534835

Landed

Done:

Wrote mozmill test for compose that shows the edit message as new memory corruption if the message has attachments, and refactored to fit in with Standard8's compose window tests, which are waiting review. Wrote up a couple tips about finding memory trounces - https://wiki.mozilla.org/User:Bienvenu/FindingMemoryTrounces

Done:

Figured out heap corruption when editing message as new/ forward inline

Done:

Knocked a few items off my review queue.

Done:

addressed review comments for dock double count patch pushed patches for 3.0 rc2 blocker and ride-along

Done:

Submitted a patch for improving some of our imap error alerts to include info about host and folder names - https://bugzilla.mozilla.org/show_bug.cgi?id=66860